Skip to content

Conversation

@joragua
Copy link
Collaborator

@joragua joragua commented Nov 6, 2025

Related Issues

App: #4695

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

Checks:

#4713 (comment)

Reports

@joragua joragua self-assigned this Nov 6, 2025
@joragua joragua linked an issue Nov 6, 2025 that may be closed by this pull request
10 tasks
@joragua joragua marked this pull request as ready for review November 10, 2025 08:40
@joragua joragua requested a review from jesmrec November 10, 2025 08:41
@jesmrec
Copy link
Collaborator

jesmrec commented Nov 10, 2025

LGMT 👍 Let's move to QA

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 10, 2025

QA checks

From / To B KB MB GB TB PB No restr.
B
KB
MB
GB
TB
PB
No restr.

Other extreme values:

1.01 PB (exceeds limit) ✅
0.1 B (same as 0) ✅
From 1 B to 1 PB: 1.000.000.000.000.000 ✅
From 1 PB to 1 B: 0,000000000000001 ✅

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 10, 2025

(1) [FIXED]

Big conversions does not seem to work.

For example:

  1. Set the quota to 100MB and Save
  2. Edit the space and try to convert it to 100 TB (100.000.000)

Current:

Not allowed, message about quota limit. My guess: it just checks the amount and not the unit

Expected:

That's posible, since 100.000.000 MB does not exceed the limit (1 PB)

Xiaomi Redmi Note 13
Android 15
8c2846ea

@joragua
Copy link
Collaborator Author

joragua commented Nov 10, 2025

(1) should be fixed with the last commit @jesmrec

Before the fix, the quota limit was defined in GB, but since unit conversion was introduced, the limit now needs to be defined in B

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 10, 2025

(1) fixed

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 10, 2025

Approved, ready to go 🚀

@joragua joragua force-pushed the feature/improvements_in_space_quota branch 2 times, most recently from c7a07d4 to d9826f4 Compare November 10, 2025 13:32
@joragua joragua merged commit cc2a35a into master Nov 10, 2025
10 checks passed
@joragua joragua deleted the feature/improvements_in_space_quota branch November 10, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Improvements in space quota (creation and edition)

4 participants